[PUSHED] Re: [PATCH] fdo#46378: Poor Resampling Image quality

Jan Holesovsky kendy at suse.cz
Mon Jun 4 07:50:46 PDT 2012


Hi Tomaz,

On 2012-06-03 at 20:46 +0200, Quikee wrote:

> I implemented Lanczos resampling for bug fdo#46378. Lanczos resampling
> is a lot better than currently available resampling methods (FAST and
> INTERPOLATE). Currently the lanczos resampling is only enabled for PDF
> export.

Great stuff, thank you so much!  I've pushed that to master

http://cgit.freedesktop.org/libreoffice/core/commit/?id=47e0df5cebc05576e55210c5dd408a6f3eb91700

with some minor modifications:

- changed sal_Bool -> bool (we prefer the native bool in the new code)
- modified one method to be void (it always returned true)
- added your real name as the author (please set your git config \
  --global user.name)
- and reverted the _LANCZOS use for the PDF export for now - sorry for
  that; but I am afraid there must be a small glitch somewhere :-(

How did I find out; I told myself "let's be bold, and default to
Lanczos" ;-) - and tried with the attached 2 patches, but from some
reason the start screen looks like the attached "start.png" then - can
you please have a look?

Thank you so much for your work - if you can fix that, and ideally add a
unit test, or few, I am all for enabling it for 3.6 even a bit later as
a late feature; hopefully we might find 2 more approvals for that :-)

All the best,
Kendy


More information about the LibreOffice mailing list