Continuing converting ScMyTables in feature/gsoc-calc-perf

Daniel Bankston daniel.dev.libreoffice at gmail.com
Mon Jun 4 10:04:06 PDT 2012


On 06/04/2012 08:38 AM, Kohei Yoshida wrote:
>
> It looks good to me.  Please push to your branch.
>
> Kohei
>
  Done.

This leaves the SetTableStyle() and small part of NewSheet() which can't 
be changed until SetTableStyle() is converted.  Also, there are the 
XShape and DrawPage methods.

On 06/01/2012 02:56 AM, Daniel Bankston wrote:
>
>
> I think most of the other methods will follow fine from there except 
> for GetCurrentXDrawPage() and GetCurrentXShapes() which are separate 
> from the merge method concern.  These methods get into things like 
> xmloff's XMLShapeImportHelper.  Do we want to go here?
>
> And of course we have already discussed trying to reexamine 
> ScMyTables::SetTableStyle() at some point.
>
I was looking at the XShape and DrawPage methods again and it would 
require some untangling, but I don't think they would be as confusing as 
SetTableStyle().

In an IRC conversation, Markus and I discussed that I work on 
ScXMLTableRowCellContext::EndElement() in xmlcelli.cxx next.  I will 
work on EndElement() now and come back later to XShape, DrawPage, and 
Styles in ScMyTables unless you guys think I should do differently.


Respectfully,
Daniel Bankston


More information about the LibreOffice mailing list