[REVIEW][3-5] fdo#33634, fdo#49438 border line drawing regressions

Miklos Vajna vmiklos at suse.cz
Wed Jun 6 01:50:43 PDT 2012


On Tue, Jun 05, 2012 at 05:28:36PM +0200, Michael Stahl <mstahl at redhat.com> wrote:
> drawing of borders in Calc looks rather ugly, the lines suddenly getting
> much fatter when zooming in etc., and there's a fix for that by moggi,
> mostly doing arithmetic on doubles and changing the hairline predicate
> from something that is right for Writer to something that is right (or
> at least not as wrong) for Calc:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c91cb08d65cd35fa8ef6eaca3677aa82fb58cbe
> 
> this fix unfortunately introduces a regression that thin lines become
> invisible when anti-aliasing is disabled, and i've come up with this
> horrible hack that seems to fix it for me:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee42895d684be9430a414adf3f569d279d437148
> 
> so i'd say we should backport both of these to libreoffice-3-5.

The second needed small fixing (SAL_UNUSED_PARAMETER is not in -3-5),
pushed now to -3-5.


More information about the LibreOffice mailing list