[PATCH] [PUSHED] dead code: remove ScDocument::DeleteNumberFormat

Thomas Arnhold thomas at arnhold.org
Thu Jun 7 10:44:32 PDT 2012


Hi Daniel,

many thanks! This was some kind to fast forward ;) Didn't see the 
rInfoItem.GetNumberFormatter()->DeleteEntry() call.

Thanks! Pushed.

Thomas

On 06/07/2012 06:25 PM, Daniel Bankston wrote:
> On 06/07/2012 10:34 AM, Thomas Arnhold wrote:
>> Hi,
>>
>> this patch removes some dead code. Please could someone review it,
>> especially the part at sc/source/ui/view/tabvwsha.cxx, to be sure it's
>> save.
>>
>> Thanks!
>>
>> Thomas
>>
>
> Hi, Thomas,
>
> I'm sure someone more knowledgeable than me will soon reply.  However, I
> think that in ScTabViewShell::UpdateNumberFormatter() only the call to
> ScDocument::DeleteNumberFormat() should be removed, and the rest should
> be left alone.  Of course this also means that the calls to
> ScTabViewShell::UpdateNumberFormatter() should not be removed.
>
>
> Respectfully,
> Daniel Bankston
>



More information about the LibreOffice mailing list