[GERRIT] gbuild migration: pyuno module

[Stephan Bergmann]

On 06/11/2012 12:17 AM, David Ostrovsky wrote:
> On 08.06.2012 15:21, Stephan Bergmann wrote:
>> * SAL_DLLPUBLIC_EXPORT was missing from
>> pyuno/source/module/pyuno_dlopenwrapper.c, so that the pyuno.so
>> wrapper did not export initpyuno.
>>
> Well it was done intentionally, my understanding was that it is not needed.

That definition of initpyuno is not preceded by any declaration of it 
that would already carry a SAL_DLLPUBLIC_EXPORT, so it is needed here to 
make the function exported at all.

>> ** We should also think about build dependencies, so that the zip file
>> gets recreated whenever its content would change.
> Yes, it was my fault: it was lost during migration. Added it again.
> Still can not see, why somebody would build pyuno, change internal
> python files in python module and then would build pyuno again?! But
> still we shouldn't break it.

"./g pull && make" could be broken by such missing dependencies.

Stephan