[PATCH] Remove unused argument from gridwin.cxx

[Eike Rathke]

Hi,

On Monday, 2012-06-11 08:18:44 +0200, Markus Mohrhard wrote:

> > As written in the previous mail, apparently, SCSTR_ALLFILTER is not used.
> > Therefore I removed SCSTR_ALLFILTER from sc/source/ui/view/gridwin.cxx,
> > where it is passed to a pFilterBox object, but has no effect.
> >
> > To me it looks that SCSTR_ALLFILTER  isn't used anywhere.
> > opengrok shows it in the soource file:
> >
> > http://opengrok.libreoffice.org/xref/core/sc/source/ui/src/scstring.src#589
> > and in the define file:
> >  http://opengrok.libreoffice.org/xref/core/sc/inc/sc.hrc#885
> > Remove it?
> >
> 
> I'm sorry but your analysis is not correct. The string is used there
> to fill the dialog with elements but I have no idea how to invoke this
> dialog. I hope that Eike may have an idea how to open this dialog,
> otherwise we may need to wait for Kohei.

That's the old AutoFilter button dialog, now obsoleted by Kohei's new
dialog implemented in LaunchAutoFilterMenu(). In fact
LaunchDataSelectMenu() now is only called with bDataSelect=true so the
entire !bDataSelect code branch and the parameter can be removed.

So, Cor's analysis indeed was correct, even if maybe not intended ;-)

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120613/042d81c5/attachment-0001.pgp>