[PATCH] Remove unused argument from gridwin.cxx

Eike Rathke erack at redhat.com
Wed Jun 13 04:52:00 PDT 2012


Hi Cor,

On Wednesday, 2012-06-13 08:20:10 +0200, Cor Nouws wrote:

> >That's the old AutoFilter button dialog, now obsoleted by Kohei's new
> >dialog implemented in LaunchAutoFilterMenu(). In fact
> >LaunchDataSelectMenu() now is only called with bDataSelect=true so the
> >entire !bDataSelect code branch and the parameter can be removed.
> 
> I see a big (and growing) difference in possibilities and use case
> for the old en new version of the autofilter. If the code still is
> there, I could try to add a Data > Filter > Autofilter simple as
> second item to the menu.
> Would that be an idea to ask at UX, or will it introduce
> code-troubles/ugliness?

I fail to see why you would like to use the old dialog again. The new
one is much prettier and offers more capabilities. Apart from that, two
different dialogs of course also would need differentiation in what is
stored, during runtime and in file, which I doubt makes sense as it is
an implementation specific behavior.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120613/41516388/attachment.pgp>


More information about the LibreOffice mailing list