[PUSHED 3-5-5] GTK: don't crash on X errors

[Michael Meeks]

On Tue, 2012-06-19 at 09:21 +0200, Miklos Vajna wrote:
> On Mon, Jun 18, 2012 at 05:01:57PM +0200, Fridrich Strba <fridrich.strba at graduateinstitute.ch> wrote:
> > Hello, I cherry-picked with my signoff to 3-6 and 3-5. We need 2 more
> > people for 3-5-5
> 
> Looks OK, +1 from me -- one more still needed.

	Sigh - I don't like it. In theory we can "do this right" (TM) - the
concept of just ignoring all X errors is IMHO busted and leads to bad X
programming.

	OTOH - adding more XSync's at the necessary places reduces performance
I guess. If we purely used gtk+'s calls instead of hard-coding X calls
in tons of places, we wouldn't have this problem - yet fixing that is
really hard in the gtk2 code I guess.

	For gtk3 this is an abomination that shouldn't be there, but ... I
guess we'll have to do this for -3-5, deeply as it sucks.

	Sigh,

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot