[REVIEW-3-5-5] Use after delete in oox

Lubos Lunak l.lunak at suse.cz
Tue Jun 19 06:20:40 PDT 2012


 Hello,

 please review and backport to 3-5 and 3-5-5 the attached patch.

 It is a stripped down version of a revert 
(http://cgit.freedesktop.org/libreoffice/core/commit/?id=831c2d9528) and 
rewrite (http://cgit.freedesktop.org/libreoffice/core/commit/?id=886e29cff7) 
in master, but I don't feel confident enough about the rewrite for a backport 
at this point, so the patch is just a band-aid. The current 3-5 code has a 
use-after-delete problem caused by the fact that it's not possible to take 
out a pointer out of a shared_ptr based container.

-- 
 Lubos Lunak
 l.lunak at suse.cz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avoid-a-crash-because-of-shared_ptr-ownership.patch
Type: text/x-diff
Size: 2619 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120619/688753fd/attachment.patch>


More information about the LibreOffice mailing list