[Libreoffice][PATCH] Prevent print settings dialog to show help button when it's called from help window

Maxime de Roucy mderoucy at linagora.com
Tue Jun 19 07:05:17 PDT 2012


Hello,

Here is some patchs :
0001 : one line, code simplification.
0002 : explicite NULL or 0 comparison in if. I don't know if LibreOffice
have a coding standard about that type of comparison ?
0003 : some rewriting of SfxViewShell::ExecPrint_Impl ; add some
comments, prevent a segfault (NULL pointer dereferencing ; add return
after "rReq.SetReturnValue(SfxBoolItem(0,sal_False))")…
0004 : Prevent the printer settings dialog to show help button when it's
called from a help window.

Regards.

-- 
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX
Tel. : 0033(0)642004909


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Change-unnecessary-pointer-dereference.patch
Type: text/x-patch
Size: 1024 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120619/f2be5f5d/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Explicit-if-statement.patch
Type: text/x-patch
Size: 1879 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120619/f2be5f5d/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Some-rewriting-in-SfxViewShell-ExecPrint_Impl.patch
Type: text/x-patch
Size: 10014 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120619/f2be5f5d/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Prevent-print-settings-dialog-to-show-help-button.patch
Type: text/x-patch
Size: 3417 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120619/f2be5f5d/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120619/f2be5f5d/attachment-0001.pgp>


More information about the LibreOffice mailing list