[REVIEW-3-5][REVIEW-3-5-5] Using system libsqlite3.dylib on Mac OS X? (fdo#50682)

[Stephan Bergmann]

On 06/20/2012 11:37 AM, Stephan Bergmann wrote:
> <https://bugs.freedesktop.org/show_bug.cgi?id=50682> "On MacOS X 10.7,
> 'import uno' crashes in the LibreOffice-provided Python" discusses a
> problem that is due to our "official" LO Mac OS X builds (based on 10.4
> SDK) bringing along their own copy of libsqlite3.dylib instead of using
> the system one (if any).

On closer inspection, the real problem appears to be an unnecessary 
setting of DYLD_LIBRARY_PATH in LO's python wrapper script.

<http://cgit.freedesktop.org/libreoffice/core/commit/?id=a164d246f2ed941fbdef19ec5b47dac1bab25509> 
"fdo#50682: Setting DYLD_LIBRARY_PATH in python script appears 
unnecessary" fixes that now.  I have tested the patch to work fine (by 
running LO's ".../program/python -c 'import uno'") on Linux 
libreoffice-3-5-5, libreoffice-3-6, and master, and on Mac OS X master 
(but the latter only with my nonstandard build environment, building 
against 10.6 SDK and with Xcode 4).  (The patch affects Linux as well as 
Mac OS X, but in both cases only --enable-python=internal builds.)  I 
have pushed to both master and libreoffice-3-6.

It would be ideal if somebody can test whether this patch continues to 
work fine on old Mac OS X (10.4, 10.5) in a stock LO build (against 10.4 
SDK).

In any case, please review and consider for backport to libreoffice-3-5 
and libreoffice-3-5-5.  I consider the patch relatively low risk, as all 
it affects is scenarios where clients call LO's python script.

Thanks,
Stephan