[PUSHED 3-5-5] Re: [PATCH] fix proposed for fdo#49178

[Petr Mladek]

Caolán McNamara píše v Po 25. 06. 2012 v 14:35 +0100:
> On Thu, 2012-06-21 at 15:13 -0700, julien2412 wrote:
> > Sorry for having forgotten review tag :-(
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=7588fa7a534a217e3949013b7c373fbb5503d466&g=libreoffice-3-5
> 
> We might have missed the boat on this, but sure, +1 from me, and with
> the assumption that Miklos's push to 3-5 is an implicit +1 for 3-5-5,
> one more +1 is required for inclusion in 3-5-5.

Heh, the code around is a bit curious. If "nSizeTableGrid >= i" fails,
the whole for cycle is skipped because it iterates via "i--". It means
that aSeparators is not initialized and some default values are used. I
am not sure that we want it.

Well, the patch solves the crasher. The test documents look reasonable
with the fix => it is better than the current state => pushed into
3-5-5.

Best Regards,
Petr