[PUSHED partial][PATCH] Prevent print settings dialog to show help button when it's called from help window

[Maxime de Roucy]

Hello,

> > 0003 : some rewriting of SfxViewShell::ExecPrint_Impl ; add some
> > comments, prevent a segfault (NULL pointer dereferencing ; add return
> > after "rReq.SetReturnValue(SfxBoolItem(0,sal_False))"
> > 0004 : Prevent the printer settings dialog to show help button when it's
> > called from a help window.
> 
> I guess we'll leave the other two until your updated patches. Right ?,
> or is 0004 still valid ?

Here is the a new 0003 and 0004 without the bug.

Regards

-- 
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX
Tel. : 0033(0)642004909


Le lundi 25 juin 2012 à 16:56 +0100, Caolán McNamara a écrit :
> On Tue, 2012-06-19 at 16:05 +0200, Maxime de Roucy wrote:
> > Hello,
> > 
> > Here is some patchs :
> > 0001 : one line, code simplification.
> 
> I've pushed this one anyway.
> 
> > 0002 : explicite NULL or 0 comparison in if. I don't know if LibreOffice
> > have a coding standard about that type of comparison ?
> 
> meh, I don't think we have any coding standards around it. But I'd skip
> this one as in the absence of a coding standard I don't see the value in
> swapping from one equally valid syntax to another.
> 
> > 0003 : some rewriting of SfxViewShell::ExecPrint_Impl ; add some
> > comments, prevent a segfault (NULL pointer dereferencing ; add return
> > after "rReq.SetReturnValue(SfxBoolItem(0,sal_False))"
> > 0004 : Prevent the printer settings dialog to show help button when it's
> > called from a help window.
> 
> I guess we'll leave the other two until your updated patches. Right ?,
> or is 0004 still valid ?
> 
> C.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Some-rewriting-in-SfxViewShell-ExecPrint_Impl.patch
Type: text/x-patch
Size: 10048 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120626/7b2f41f5/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Prevent-print-settings-dialog-to-show-help-button.patch
Type: text/x-patch
Size: 3419 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120626/7b2f41f5/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120626/7b2f41f5/attachment-0001.pgp>