Including a patch from AOO...

[Dennis E. Hamilton]

I'm rather fond of if (A ? !B : A) myself [;<).

I agree.  if (A && !B) is functional and a trifle.  

This is not a legal opinion.  But if anyone on AOOi is angry about it, it will just make us look ridiculous.  There is no lack of opportunities for us to do that without getting this fussy about something that is good for all of us to handle properly.  Providing attribution to the AOOi bugzilla and/or fix might be nice.

 - Dennis

-----Original Message-----
From: libreoffice-bounces+dennis.hamilton=acm.org at lists.freedesktop.org [mailto:libreoffice-bounces+dennis.hamilton=acm.org at lists.freedesktop.org] On Behalf Of Ivan Timofeev
Sent: Wednesday, June 27, 2012 08:20
To: michael.meeks at suse.com
Cc: Michael Stahl; libreoffice at lists.freedesktop.org
Subject: Re: Including a patch from AOO...

Hi Michael,

thanks for the explanations.

On 27.06.2012 13:56, Michael Meeks wrote:
> Please just re-implement the fix in a
> different way - and/or if this is a really key-fix we can re-base that
> one file in 3.6.

I am scratching my head - how could one re-implement

+  if (A && !B)
-  if (A && B)

or any other trivial fix? I believe the following logic-manipulating 
approach is pure dotage:

+  if (A && !B)
-  if (A && !(!B))

+  if (A && !B)
-  if (!(!A || !B))

isn't it? :) Or one need to rewrite UndoManager...

I don't know if the patch can be considered a key-fix, the bug title is:

"Undo broken in several contexts (Basic Editor, Math Editor, Calc Input 
Line, MultiLine controls, etc)"

(you know, it depends on the definition of the key-fix... :) From my 
point of view it can, but I am an inveterate bug-hater.

Regards,
  Ivan
_______________________________________________
LibreOffice mailing list
LibreOffice at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice