Weird code found by clang

[Tor Lillqvist]

> Probably it should be pFields != pFieldsEnd ? See original commit:
> http://opengrok.libreoffice.org/xref/core/svtools/source/dialogs/addresstemplate.cxx?a=true&r=447a63cfb6d6d3dff63af72490a4c0b96295db6d#250

Ah yes. That variable had then been removed as unused (which it was),
while the right thing would have been to fix the for loop's test
instead to use it. Will re-introduce that pFieldsEnd and use it in the
test. Hopefully this will then fix some user-visible bug too.

--tml