[REVIEWED] [PUSHED 3-5] fix for fdo#46825, crash copying a chart

Kohei Yoshida kohei.yoshida at gmail.com
Fri Mar 2 19:13:44 PST 2012


On Fri, Mar 2, 2012 at 7:08 PM, Markus Mohrhard
<markus.mohrhard at googlemail.com> wrote:
> Hey,
>
> [1] fixes a crash when you copy a chart in the document. The problem
> is that you should not create a uno::Sequence with new because the
> uno::Sequence copy c'tor is creating a flat copy. This will later
> result in a double delete.
>
> I think the patch is quite save and fixes a crash and therefore should
> be included into at least 3-5 and if still possible in 3-5-1.

> [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f2d3c47ad40039a842fa09d98137155dcfdfe9e

The change looks safe.  Pushed to the 3-5 branch with my sign-off.

Kohei


More information about the LibreOffice mailing list