[PATCH]fdo45671 writer par. bg color simplified code for split button

Winfried Donkers W.Donkers at dci-electronics.nl
Mon Mar 5 08:38:47 PST 2012

Ivan Timofeev wrote (5 maart 2012 17:23)
>So, a call without arguments meant "set transparent background", that
>corresponds to the "No Fill" button in the picker. I'd suggest recover
>this code, otherwise "No Fill" does not work for me. What do you think?

(I hope I understand what you mean.) The original 'No Fill'  code (from 
before fdo 44611) did set the background transparent when the
execute function was called without arguments. With fdo 44611 I 
changed the single button (always pick colour form palette) to a split
button (with the default setting as transparant background). I used a
similar construction as with writer font colour and writer font 
background colour, i.e. storing the last used colour (which is kept 
within the button) in the shell as well. I didn't like that and found a way
to avoid that: passing the colour as argument. I changed my original
patch fdo 34425 first, fdo 44611 next (both under fdo 45671), and
fdo 45688 will follow later today.
You can select transaparent background from the palette when the
last used colour was different and apply that to any selected 
paragraph. So I don't think that functionality is lost.
Is this the anwser you are looking for?


More information about the LibreOffice mailing list