[REVIEW][3-5] disarm bogus unoapi XPropertySet test

[Michael Stahl]

On 06/03/12 13:38, julien2412 wrote:
> see full error log at 
> /home/julien/compile-libreoffice/libo/workdir/unxlngx6/JunitTest/sw_unoapi/done.log

> http://nabble.documentfoundation.org/file/n3803458/done.log.zip done.log.zip 

your log says that the XPropertySet test for an SwXTextSection failed:

> ***** State for sw.SwXTextSection::com::sun::star::beans::XPropertySet ******
> [sw.SwXTextSection::com::sun::star::beans::XPropertySet::setPropertyValue()] is testcode: [setPropertyValue()] - PASSED.FAILED

specifically setting this property:

> LOG> setting property 'LinkRegion' failed

looking at my log file for this test, the properties are tested in a
completely different order, and setting the LinkRegion doesn't fail for
me; thus i conclude that this unoapi test framework tests properties in
a random order and expects that to actually work, which is yet more
evidence to back the hypothesis that unoapi tests are completely
braindamaged.

so i've decided to disable the check that the value of the property is
actually different after calling setPropertyValue:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=73867da36960adf8b79ff34c7094c63aa5a05940

please somebody review and apply it to libreoffice-3-5 as well.

> Of course, it's a different thing.
> 
> Now :
> - should I file a bug for initial problem (or is too late because you patch
> fixes it) ?

i've filed fdo#47021 since the patch doesnt fix it :)