[PUSHED][PATCH] fdo#46939: Crash after trying to rename autotext entry

Caolán McNamara caolanm at redhat.com
Thu Mar 8 06:08:36 PST 2012

On Wed, 2012-03-07 at 04:20 +0100, Dézsi Szabolcs wrote:
> xRoot->renameElement ( aOldStreamName, aNewStreamName );
> It can be seen a few lines later, that xBlkRoot is handled the same way,
> catching a container::ElementExistException, but doing nothing in the catch
> block.

Yeah, that logic suggests that if we catch in one place, we should catch
in the other, so PUSHED.

Though I see the reason an exception is thrown is because the oldname
and the newname are the same, i.e. the rename doesn't make sense, it
already has that name. So I stuck the offending block inside the
existing new != old test.


More information about the LibreOffice mailing list