String literals, ASCII vs UTF-8

Lubos Lunak l.lunak at
Tue Mar 13 09:08:11 PDT 2012

On Tuesday 13 of March 2012, Olivier Hallot wrote:
> Are we going to remove  RTL_CONSTASCII_USTRINGPARAM from all the code?
> There a 33599(*) lines in whole code...

 That is the plan, but I still want to give it a little more time in case 
somebody runs into a problem. I just massively broke the build on mac on 
Monday with my OString changes because the ancient gcc we use there had a 
problem, and I wasn't very happy with the prospect of reverting even what 
I've committed only so far. But eventually yes, although it's probably not 
going to be all (e.g. the tools String class still uses it and should be 
instead converted to rtl strings, and there may be few more cases where the 
macro makes sense).

> Can it be automated?

 Not with something as simple as grep&sed I think, because of what I said 
above. But I've just found out about the clang compiler and switched to it, 
and it seems one of its nice features should be the ability to analyze and 
rewrite code, in which case a change like this or e.g. the 'str.length() == 
0' -> 'str.isEmpty()' change could be done reliably by writting some clang 
code. I still need to actually check that.

 Lubos Lunak
 l.lunak at

More information about the LibreOffice mailing list