[REVIEW: 3-5, 3-4] fdo#43932 setting paper tray from print dialog

[Ivan Timofeev]

Hi David,

actually, your fix was my first attempt to solve the bug. It solved the 
UI problem, I remember. And then I decided to clean-up the code a bit... 
You might see my patch. :)

But I cannot ever understand, how it fixes the real problem (setting 
paper tray).
https://bugs.freedesktop.org/show_bug.cgi?id=43932#c17 says that it is 
not a GUI-problem...


Technically:

The call chain is

   printFilteredPage -> getFilteredPageFile -> getPageFile -> modifyJobSetup

where modifyJobSetup sets a paper tray, taking in account a tray that 
was set for a single page; and then there is the following code inside 
printFilteredPage

     if( mpImplData->mnFixedPaperBin != -1 &&
         mpImplData->mpPrinter->GetPaperBin() != 
mpImplData->mnFixedPaperBin )
     {
         mpImplData->mpPrinter->SetPaperBin( mpImplData->mnFixedPaperBin );
     }

which sets a paper tray again. (?)

In my patch I used mpImplData->mpPrinter->GetPaperBin() in 
printFilteredPage to control what tray is currently used, and that 
showed right trays. So I am confused. %-)

Regards,
Ivan