[PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

Albert Thuswaldner albert.thuswaldner at gmail.com
Wed Mar 14 16:02:51 PDT 2012

Hi Markus,
So I have hacked on this a bit, progress has been slow, detours and so
on. Anyhow, I think have now completed the step 1, i.e changed the
underlying code removing the static limit. I've have tried to keep
much of the old structure for now, probably do a re-factoring once all
bits are in place.

To test this I have temporarily inserted a fourth sort key to check
that it all works as expected.

For part 2 the UI bits, I (ironically) thought of using Robert's work
on "unlimited number of conditions for conditional formatting"[1]
as kind of a "cheat-sheet" for my own implementation.

Then, yesterday I saw your comment [2], which on a closer thought I
can agree on.

The question is what to do instead? I'm kind of stuck in the "old"
thinking to use the scroll offset to alter the widgets in-place. Could
you give me any pointers?
Has anything similar been made somewhere else in LO, that I could "copy"?  :)

I've attached a patch of the work done so far, If you have the time to
quickly review it, I would appreciate that. As I said I probably will
reorganize the code once the all the bits are in place, and make it
more elegant in places.

BTW: I have a Patch that partly fixes fdo#43937, but I guess since it
needs a greater overhaul anyway,  that's of no interest?

Thanks for your help.

[1] http://cgit.freedesktop.org/libreoffice/core/log/?qt=author&q=Robert+Dargaud
[2] https://bugs.freedesktop.org/show_bug.cgi?id=43937#c4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fdo-45747-remove-the-limitation-to-3-sort-entries-in.patch
Type: application/octet-stream
Size: 73823 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120315/e077e9c6/attachment-0001.obj>

More information about the LibreOffice mailing list