[REVIEW-3-5] Clear whole layer in slideshow sprites fdo#45219

Thorsten Behrens thb at documentfoundation.org
Fri Mar 16 10:09:47 PDT 2012


Hi there,

  http://cgit.freedesktop.org/libreoffice/core/commit/?id=d32cf8d820be839c7303e3c5962c17f64cac2812

fixes the "ugly dark rectangle in part of the shape" subset of
fdo#45219 - because the clearing rectangle was errorneously offset
by the topleft corner of the sprite - it should rather start at
(0,0).

Second part of the fix came up during code review -
maLayerBoundsPixel is lazy-initialized inside the getCanvas() call,
and evaluation order of function parameters is unspecified.

Cheers,

-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120316/17a1c647/attachment-0001.pgp>


More information about the LibreOffice mailing list