[PATCH] Windows lcms2 library import fix

Lubos Lunak l.lunak at suse.cz
Sat Mar 17 15:43:32 PDT 2012


 there is a link error in writerperfect's cdrimport, caused by libcdr/lcms2 
libraries. So as far as I understand it, on Windows a library uses dllexport 
when it is being built and dllimport when something else is built against it. 
Our libraries achieve this by detecting they're being built and doing 
dllexport, otherwise dllimport. This is not the case with lcms2, which uses 
dllexport if CMS_DLL_BUILD is defined (which is done in its project file), 
and uses dllimport, if CMS_DLL is defined, which is not done anywhere (I 
assume the expectation is that anything that touches lcms2 even with a 
ten-foot pole does this define). Is the attached patch a good way to solve 
the problem as well? I don't know what the usual idiom of handling this is, 
so I'd like somebody to check.

 Lubos Lunak
 l.lunak at suse.cz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lcms.patch
Type: text/x-diff
Size: 1180 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120317/d3686f9d/attachment.patch>

More information about the LibreOffice mailing list