Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx
sbergman at redhat.com
Tue Mar 20 00:53:19 PDT 2012
On 03/19/2012 10:25 PM, julien2412 wrote:
> remarks :
> - I replaced this
> nChar>= 0xff62&& nChar< 0xff64
> by this for readability
> nChar == 0xff62 || nChar == 0xff63
> - I added in the outer "if", "nChar == 0xffe3" because if not, "nChar ==
> 0xffe3" in the inner "if" is useless.
> Is this patch ok ?
> If yes, I can commit and push it on master.
I at least know just as little as anybody else whether this is right or
not (the U+FFE3 FULLWIDTH MACRON still looks odd here, but who knows).
Presumably the patch is fine, but to know for sure somebody would have
to dig out what exactly the code is actually supposed to do.
More information about the LibreOffice