[PATCH] Missing sub-menu arrows with 3.5.x and GTK < 2.15

Michael Meeks michael.meeks at suse.com
Tue Mar 20 04:32:10 PDT 2012

Hi David,

On Mon, 2012-03-19 at 17:48 -0400, David Bolen wrote:
> Even if the implementation stinks using it was easy enough :-)


> (a) Direct use of gtk_widget_class_find_style_property in lieu of the
> version check.

	This looks really nice.

> (a) is a more conservative change, but (b) feels a little nicer in
> terms of less overhead and redundant queries in actual operation.

	Heh - so, gtk+ spends it's life doing string lookups all over the
place, and the overhead is negligible compared to what the client side
rendering is going to do with your CPU ;-)

> it actually feels like more of this code should be able to be hoisted
> to a less frequent spot (initialization or something), since I can't
> imagine how often the properties change value during run-time?  But I
> doubt it's a performance bottleneck.

	Yep - looks nice.

> One other curiosity - GTK 2.24.4 actually uses a value of 0.80 for
> arrow-scaling, but I can absolutely say that the arrows are nowhere
> near 0.80 of the menu font, and using 0.80 under GTK 2.12 looks
> ridiculously large.  I've actually dropped my default of 0.5 to 0.4 as
> it more accurately matches 2.24 (plus the prior LO 3.4 on my 2.12
> system).  I think I actually liked 0.5 a little better myself, but
> figure trying to match existing behavior should win.


>   I'm guessing
> being 1/2 of the 0.8 property value isn't a coincidence, so there must
> be some other scaling going on under the covers somewhere under 2.24
> since obviously this code uses the scaling factor the same way in both
> cases.

	Thanks for unwinding all that and the nice fix, I think Petr picked it
and it should be in 3.5.2.

	Any other gtk+ theming nasties annoying you ? :-)

	All the best !


michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list