[PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

Albert Thuswaldner albert.thuswaldner at gmail.com
Tue Mar 20 12:14:37 PDT 2012

Hi Markus,

On Thu, Mar 15, 2012 at 04:27, Markus Mohrhard
<markus.mohrhard at googlemail.com> wrote:
> Hello Albert,
> I have a simple idea that shouldn't be too complex to implement. I
> think we can agree that only the sort entries are the difficult part.
> I would create a control for an entry an instantiate this one for each
> new sort entry. I think we do similar things for several other
> dialogs, e.g. SvTabListBox with simple entries or the document
> properties dialog with more complex entries.
Great, Let me know if there is anything that I can do to help.

> Just two small comments. I think it would be a good idea to group the
> three entries in ScSortParam into a own struct so that we only need
> one vector. That will make it easier to keep the entries in sync.
> And you have a lot of whitespace changes. Can you check your editor
> why it replaces so many spaces with tabs. It is quite difficult to
> review it otherwise.

Sorry for the messy patch, I didn't check it properly prior to posting
it. I have reworked the patch and also split it up into two.

Now the first patch contains only the internal rework to remove the
limits and converting the data containers from arrays to std:vector.
I've also grouped the three entries in ScSortParam into a own struct
as you suggested, which resulted in quite a number of changes.

Once reviewed this patch can be pushed directly to master since it is
self contained and doesn't change the old
behavior, me thinks.

The second patch is for test purpose only. It basically adds a fourth
sort key when you press the "Add" button.

>> BTW: I have a Patch that partly fixes fdo#43937, but I guess since it
>> needs a greater overhaul anyway,  that's of no interest?
> Sure it is. If it is simple and safe we can of course use it for 3-5
> and until it is fixed in master there too.

Testing my proposed patch some more, I realize it causes more new
problems than it solves. I'll
 have another look at it later.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fdo-45747-remove-the-limitation-to-3-sort-entries-in.patch
Type: text/x-patch
Size: 60841 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120320/da68d060/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fdo-45747-temporary-patch-adding-4th-sort-key.patch
Type: text/x-patch
Size: 7809 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120320/da68d060/attachment-0003.bin>

More information about the LibreOffice mailing list