[PUSHED][PATCH] Remove unused code

Chr. Rossmanith ChrRossmanith at gmx.de
Tue Mar 20 13:26:33 PDT 2012

Am 20.03.2012 15:56, schrieb Caolán McNamara:
> On Tue, 2012-03-20 at 13:54 +0000, Caolán McNamara wrote:
>> Yeah, in unused.easy I see that the PresenterAnimator::PresenterAnimator
>> ctor is never called, and its the only constructor, so one is never
>> instantiated, so you can remove the whole thing without loss of
>> functionality.
> Whoops, its PresenterAnimation (not PresenterAnimator) which has only
> one ctor that is never used and so is never instantiated and is trivial
> to remove.
A PresenterAnimation could be instantiated here

     ModeChangeAnimation (
         const ::boost::shared_ptr<PresenterSprite>& rpSprite,
         const Reference<rendering::XSpriteCanvas>& rxCanvas)
         : PresenterAnimation (0, 1000, 20),

in PresenterWindowManager.cxx - iff ModeChangeAnimation would be used 
anywhere. I can't find any place where it is used. Double check would be 
nice. So first ModeChangeAnimation would have to go, then 
PresenterAnimation could be removed as well.


More information about the LibreOffice mailing list