[PATCH] Compilation fix - GTK print dialog headers for GTK < 2.14

David Bolen db3l.net at gmail.com
Tue Mar 20 14:58:45 PDT 2012


This fell out when I was working on my last patch for sub-menu icons.
Initially building with GTK failed on my system due to a missing
gtkunixprint.h header, which I worked around by just manually
disabling ENABLE_GTK_PRINT.

Afterwards I took another peek, and it looks like the problem is that
gtkunixprint.h was only added in GTK 2.14, so the attached patch fixes
compilation with older GTKs if they have the older setup.

I almost didn't send this because while it compiles and runs on my GTK
2.12 system without errors, I seem to get some sort of print dialog
even with ENABLE_GTK_PRINT disabled, so am not entirely certain what
it affects.  I also don't have a GTK 2.14+ system to actually compile
on at the moment.  But the patch is pretty easy to inspect visually
and a successful build seems a better option than a compilation
failure, so...

-- David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gtk-print.patch
Type: application/octet-stream
Size: 479 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120320/d842f991/attachment.obj>


More information about the LibreOffice mailing list