[[REVIEW][3-5-2] fdo#47717, fdo#45562 sw: yet more border painting regressions (was: Re: [REVIEW][3-5][PUSHED] fdo#42750 sw: thin table borders hidden by subsidiary lines)

Petr Mladek pmladek at suse.cz
Tue Mar 27 01:11:23 PDT 2012

Michael Stahl píše v Pá 23. 03. 2012 v 17:44 +0100:
> On 20/03/12 12:19, Cedric Bosdonnat wrote:
> > Hi Michael,
> > 
> > On Fri, 2012-03-16 at 23:29 +0100, Michael Stahl wrote:
> >> this fix introduces a new array to store the borders and paints them
> >> after the subsidiary lines are done, effectively on top of the
> >> subsidiary lines.
> >>
> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=804d0a896731629397c5328c13c04a45bc55f459
> > 
> > Thanks for the patch. I apologize as I should have done that a lot
> > earlier. I cherry-picked and pushed it to -3-5.
> unfortunately it turns out that the patch introduced a regression,
> fdo#47717, which is hopefully fixed with this one (as is fdo#45562,
> which is about borders vs. hellish drawing objects), so please consider
> it for libreoffice-3-5-2:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=1024c172a5bfb3d85a86fcf7a046aa2b03950edd
> because up until a week ago my knowledge of Writer's drawing code was
> precisely zero, it would be a good idea to test this a bit.  in case
> something is still wrong i'd strongly consider reverting the original
> commit (0f0896c26fb260d1bbf31d7a886df3f61837f0f2).

The other commit did not fix all problems, so we should go the reverting
way for 3.5.2. Cedric is against reverting the old
0f0896c26fb260d1bbf31d7a886df3f61837f0f2 because some other things
depends on it and it could cause another regressions.

So, I reverted only the 804d0a896731629397c5328c13c04a45bc55f459 in
3-5-2, see
This will bring us to the state of 3.5.1.

Best Regards,

More information about the LibreOffice mailing list