[PATCH] fdo#39749: calc unit test writing

Markus Mohrhard markus.mohrhard at googlemail.com
Sat Mar 31 09:15:17 PDT 2012


> I'm submitting a patch for the easy hack 39749. I have written one test that
> tests the setbackgroundcolor function in ScDocFunc class

Great to have you working on this, I have just some small comments:

- Could you please build with your patch before submitting? The patch
was in several ways broken and I had to fix it to get it build.

- Can you set your git settings so that it sets the author name
correctly. I adjusted it in your patch.

- You still had trailing whitespaces in your commit. Can you try to
set-up your editor to remove them or remove them when our git hook
complains about them?

Except for these smaller problems the patch was good and I pushed it
with my small modifications.

Can you confirm that your patch is under MPL/LGPLv3+?


More information about the LibreOffice mailing list