[REJECTED][PATCH]calc and row height for numerical cells with text wrap

Eike Rathke erack at redhat.com
Mon May 14 10:15:30 PDT 2012


Hi Laurent,

On Monday, 2012-05-14 17:30:47 +0200, Laurent Godard wrote:

> Here is a small patch that tend to address the following problem
> 
> a row set to optimal height
> a cell containing a value
> formated with # ###,00
> vertically centered
> and text wrapping allowed
> 
> actually the row height is not adjusted
> 
> The patch removes the test on "numerical cell".
> 
> Then, now the row height of the formatted cell is correct when the
> text is wrapped over lines (may be some confusion with line break
> versus text wrapping regarding ATTR_LINEBREAK)

Those lines were added by Kohei as a fix for
https://issues.apache.org/ooo/show_bug.cgi?id=111387
I think we should not remove them.

In fact the display string should not be wrapped at all, displaying
12345,6789 as

12 34
 5,68

isn't very sensible.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120514/7daae806/attachment.pgp>


More information about the LibreOffice mailing list