[PATCH] [REVIEW:3-5] fdo#48345 display wrong datasets when scrolling through tables

Lionel Elie Mamane lionel at mamane.lu
Tue May 15 10:01:32 PDT 2012


Attached patch fixes fdo#48345, namely that when one scrolls back in a
table view, a wrong line is shown. See screenshot at
https://bugs.freedesktop.org/attachment.cgi?id=61072
and detailed analysis at
https://bugs.freedesktop.org/show_bug.cgi?id=48345#c2

Briefly, OKeySet->next() did not refresh the row after moving to the
next row, only in the case where not all data was fetched yet. So we
still had another row there, and that's the one that was shown. The
first patch makes OKeySet->next() refresh the row always.

The second patch is cleanup and should probably not go to 3.5;
however, the version I tested is with *both* patches applied, so
<shrug>. If you are willing to test with only the first patch, then by
all means apply only the first.

-- 
Lionel


More information about the LibreOffice mailing list