[PUSHED] Re: [REVIEW:3-5-4] Missing symbol when linking oox

[Lubos Lunak]

On Wednesday 16 of May 2012, Miklos Vajna wrote:
> On Wed, May 16, 2012 at 06:04:19PM +0200, Petr Mladek <pmladek at suse.cz> 
wrote:
> > we need two more approvals for
> > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id
> >=619b692dfd5c19fb7de344d25bcbb8689e5dc940 for 3-5-4 branch.
>
> Looks OK to me. Sorry, I obviously did not build-test the patch on
> Windows when I cherry-picked it.

 +1, pushed.

 I didn't fully follow the discussion on IRC, but I'd agree that the proper 
solution might be removing the 'extern', 'extern inline' doesn't make much 
sense in practice.

-- 
 Lubos Lunak
 l.lunak at suse.cz