[REVIEWED] [3.5] [PUSHED] crasher fdo#45987

Kohei Yoshida kohei.yoshida at gmail.com
Fri May 18 11:39:03 PDT 2012


On Fri, May 18, 2012 at 1:43 PM, Markus Mohrhard
<markus.mohrhard at googlemail.com> wrote:
> Hello Noel, Kohei,
>
> I think [1] is a better patch for 3-5. I'm still not happy with it
> because I had hoped that we could init the number of sheets already in
> the constructor but this works only while loading a file and not when
> we create an empty one. This hack is a bit dirty but was the only
> useful place that already knows about the number of sheets and does
> not force us to create some more ugly hacks. It just makes sure that
> the number of sheets in ScViewData and ScDocument is the same.
>
> It is a safe fix and we can include it in 3-5.

I concur.  I also verified that this change fixes the reported bug.

Pushed to 3-5 with my sign off.

Kohei


More information about the LibreOffice mailing list