[PUSHED:3-5][REVIEW:3-5-4?] fdo#48914 uninstall process should remove .pyc files from install directory

Petr Mladek pmladek at suse.cz
Mon May 21 08:49:11 PDT 2012


David Tardon píše v Pá 18. 05. 2012 v 12:44 +0200:
> On Wed, May 16, 2012 at 12:56:47PM +0200, Andras Timar wrote:
> > Hi,
> > 
> > When install location is writable to user (typical on Windows XP),
> > Python generates .pyc files. We can remove them using the RemoveFile
> > table in MSI. We generate an entry for each .py file in the install
> > set.
> 
> I did not actually try it, but the code looks sensible. Well, except the
> variable names ($filesinproductlanguageresolvedarrayref, seriously? :-),
> but these are not new...

It is pushed in 3-5, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=86d1dc9737a73e2034fb60e09c820b4fee64d83a

It looks fine to me. If we get one more approval, we could even add it
into 3-5-4 branch.


Best Regards,
Petr



More information about the LibreOffice mailing list