[PATCH] fdo#50162 merge rtlbootstrap.mk into configure.in

David Ostrovsky david.ostrovsky at gmx.de
Mon May 21 23:38:55 PDT 2012


Hi Rene,

thank you for review and comments!
I was indeed not sure with arm and was told on irc that eabi would be 
the right way to go...
And who really cares, which ARCH are we using for Mips ;-)
Anyway I fixed it accordingly and here is the new version.

Ciao
David

On 21.05.2012 23:17, Rene Engelhard wrote:
> Hi,
>
> On Mon, May 21, 2012 at 09:39:52PM +0200, David Ostrovsky wrote:
>> with this patch sal/rtl/source/macro.hxx is merged into configure
>> process and
>> rtlbootstrap.mk is not generated any more.
>       arm*)
>           CPU=R
>           CPUNAME=ARM
> +        RTL_ARCH=ARM_EABI
>           EPM_FLAGS="-a arm"
>           OUTPATH=unxlngr
>           ;;
>
> is wrong.
>
> arm*-linux-gnueabi) is RTL_ARCH=ARM_EABI.
> arm*-linux) is RTL_ARCH=ARM_OABI.
>
> Yes, arm oabi is dead...
>
>       mips64el)
>           CPU=M
>           CPUNAME=GODSON
> +        RTL_ARCH=MIPS_EB
>           EPM_FLAGS="-a mips64el"
>           OUTPATH=unxlngmips
>           ;;
>       mipsel)
>           CPU=M
>           CPUNAME=GODSON
> +        RTL_ARCH=MIPS_EB
>           EPM_FLAGS="-a mipsel"
>           OUTPATH=unxlngmips
>           ;;
>
> is obviously also wrong. it's called mipsel for a reason. Yes, it's little endian,
> so MIPS_EL would be right here.
>
> I bet that more of this might be wrong,
> I actually think that getting these values from what the compiler gives is safest as
> that one *does* know what it's supoosed to compile for.
>
> Regards,
>
> Rene



More information about the LibreOffice mailing list