[PATCH] fdo#35973 - [EasyHack] Remember the state of the sidebar pane in Impress

Rob Snelders libreoffice at ertai.nl
Mon May 28 08:08:59 PDT 2012


Hi,

I have changed a lot of the things Tor wrote about in the earlier email. 
Except the issue below and the issue about IsDisposing.
I also saw another little bug in the patch and solved that.

--
Greetings,
Rob Snelders

Op 28-05-12 16:55, Tor Lillqvist schreef:
> Rob pointed out to me that much of his additions is in fact based on
> existing code, svtools/inc/svtools/miscopt.hxx etc. Which uses a
> similar oddly phrased comments, weird _Impl class with "reference
> counting" that is not a Pimpl, and other potential signs of
> micro-optimization for dubious gain. So is it OK then, and I am just
> being too sensitive? Since when am I a C++ expert anyway? Or should we
> ask him to try to simplify both the existing code and his own?
>
> --tml



More information about the LibreOffice mailing list