[PATCH] Re: 1 sheet by default [was Re: Tinderbox failure, Linux-RHEL6-x86_64 at 14-with-check, MASTER, last success: 2012-05-15 18:12:02]

Jan Holesovsky kendy at suse.cz
Thu May 31 02:13:50 PDT 2012


Hi Astron,

On 2012-05-30 at 15:53 +0200, Stefan Knorr (Astron) wrote:

> With some dumbluck and [1], I've managed to get it down to 1 failing test.
> 
> My approach so far was to just unconditionally add a sheet (in the
> case of the XMLStylesExporter and XMLSettingsExporter I just made sure
> these tests actually ran on Sheet 1 (=0), not Sheet 2 (=1)).
> Since I guess my approach is less than optimal, do tell me if I need
> to wrap stuff in try/catch or so. Or, if I should ask LibO how many
> sheets there are before creating a new one. Or something else.

Great stuff, I've pushed that :-)

> About the last failing test, sc_unoapi/ScModelObj, I am unsure where
> it needs the second sheet, so I didn't add anything yet. Advice
> appreciated.

Stephan is just looking at this one...

Thank you,
Kendy



More information about the LibreOffice mailing list