[PATCH] Change in core[libreoffice-3-6]: resolved fdo#56278 broadcast deletion to dependent formula c...

Eike Rathke (via Code Review) gerrit at gerrit.libreoffice.org
Wed Nov 14 13:51:29 PST 2012


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1069

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/1069/1

resolved fdo#56278 broadcast deletion to dependent formula cells

Consolidated changes for fdo#56278 fdo#54074 fdo#53364 fdo#55059 (and
earlier i#99844 and i#101869). The replacement cell for the broadcaster
to inform listeners, if any, is transferred the broadcaster and owns it,
the remembered formula cell never does. When broadcasting the change use
the replacement cell instead of the remembered formula cell. Don't
fiddle around with ReleaseBroadcaster() at the remembered cell, we don't
delete twice and now also don't leak.

(cherry picked from commit 8165bfa2afbe828caf37df57b83cb31bef2559cb)

Change-Id: Ia11b6d3d751c784af64aaed05f8508887f869a80
---
M sc/source/core/data/column3.cxx
1 file changed, 34 insertions(+), 31 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1069
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia11b6d3d751c784af64aaed05f8508887f869a80
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Eike Rathke <erack at redhat.com>



More information about the LibreOffice mailing list