[PATCH] Change in core[libreoffice-3-6-4]: resolved fdo#56278 broadcast deletion to dependent formula c...

Eike Rathke (via Code Review) gerrit at gerrit.libreoffice.org
Thu Nov 15 04:54:56 PST 2012


I have submitted a patch for review:


To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/1081/1

resolved fdo#56278 broadcast deletion to dependent formula cells

Consolidated changes for fdo#56278 fdo#54074 fdo#53364 fdo#55059 (and
earlier i#99844 and i#101869). The replacement cell for the broadcaster
to inform listeners, if any, is transferred the broadcaster and owns it,
the remembered formula cell never does. When broadcasting the change use
the replacement cell instead of the remembered formula cell. Don't
fiddle around with ReleaseBroadcaster() at the remembered cell, we don't
delete twice and now also don't leak.

(cherry picked from commit 8165bfa2afbe828caf37df57b83cb31bef2559cb)

Reviewed-on: https://gerrit.libreoffice.org/1069
Reviewed-by: Norbert Thiebaud <nthiebaud at gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud at gmail.com>
(cherry picked from commit a6e622029b8f1c450b9d535e94212bf06666acf3)

Change-Id: I63351bfcd9d25cdb2c8618b2dbf45a9430e97daf
M sc/source/core/data/column3.cxx
1 file changed, 34 insertions(+), 31 deletions(-)

To view, visit https://gerrit.libreoffice.org/1081
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63351bfcd9d25cdb2c8618b2dbf45a9430e97daf
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-4
Gerrit-Owner: Eike Rathke <erack at redhat.com>

More information about the LibreOffice mailing list