[PATCH] API CHANGE: add a "position" parameter to XParagraph/TextPor...

Miklos Vajna (via Code Review) gerrit at gerrit.libreoffice.org
Sat Nov 24 12:31:31 PST 2012


I have submitted a patch for review:


To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/1159/1

API CHANGE: add a "position" parameter to XParagraph/TextPortionAppend methods

So we can use the new RTF import for clipboard pastes in Writer without
inserting text content to the end of the document only.


- SwXText::insertTextPortion: the MovePara() call is removed, as all it
  did was
  trying to move the cursor beyond the end of the document.
- SwRTFReader::Read: the double fake paragraph insertion / deletion is
  motivated by the ODT filter.
- RtfFilter::filter: if TextInsertModeRange is not passed, then the
  is not changed.

Change-Id: I24cddb00a78e3b798e7d88764e59e6a77a6e98a4
Helped-by: Michael Stahl <mstahl at redhat.com>
M editeng/inc/editeng/unotext.hxx
M editeng/source/uno/unotext.cxx
M offapi/com/sun/star/text/XParagraphAppend.idl
M offapi/com/sun/star/text/XTextPortionAppend.idl
M sw/inc/unotext.hxx
M sw/inc/unotextrange.hxx
M sw/source/core/unocore/unotext.cxx
M sw/source/filter/rtf/swparrtf.cxx
M writerfilter/inc/dmapper/DomainMapper.hxx
M writerfilter/source/dmapper/DomainMapper.cxx
M writerfilter/source/dmapper/DomainMapper_Impl.cxx
M writerfilter/source/dmapper/DomainMapper_Impl.hxx
M writerfilter/source/filter/ImportFilter.cxx
M writerfilter/source/filter/RtfFilter.cxx
14 files changed, 266 insertions(+), 36 deletions(-)

To view, visit https://gerrit.libreoffice.org/1159
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I24cddb00a78e3b798e7d88764e59e6a77a6e98a4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Miklos Vajna <vmiklos at suse.cz>

More information about the LibreOffice mailing list