[REVIEW 3-6-4 2/3] fix for fdo#57451, don't throw exception through methods with throw()

Stephan Bergmann sbergman at redhat.com
Sat Nov 24 16:11:21 PST 2012


On 11/25/2012 12:56 AM, Michael Meeks wrote:
>
> On Sat, 2012-11-24 at 19:04 +0100, Markus Mohrhard wrote:
>> [1] and [2] fix a crash in calc import that happens if the sax parser
>> is throwing an exception when reading the document properties.
>
> 	Looks great to me - pushed to 3-6- need another couple for -3-6-4.

Looks good to me too (and Markus explained offline to me that returning 
true from ExcelFilter::importDocument in case of catching an exception 
is right indeed).

So one more +1 needed for -3-6-4.

Stephan



More information about the LibreOffice mailing list