[PATCH] proposed patch for fdo56549 CRASH in menu 'Format → Autocorrect → Apply and Edit Changes'

[julien2412]

Hello,

I propose a patch for fdo#56549 (see
https://bugs.freedesktop.org/show_bug.cgi?id=56549):
https://bugs.freedesktop.org/attachment.cgi?id=70538

I think (not sure at all) that the problem was that at the end
_GetAutoFmtNameLst(), destructor ~ImpAutoFmtNameListLoader for aTmp is
called and must destroy (i don't know how) pLst vector
     239 void ShellResource::_GetAutoFmtNameLst() const
    240 {
    241     std::vector<String>* pLst(pAutoFmtNameLst);
    242     pLst = new std::vector<String>;
    243     pLst->reserve(STR_AUTOFMTREDL_END);
    244     ImpAutoFmtNameListLoader aTmp( *pLst );
    245 }
see
http://opengrok.libreoffice.org/xref/core/sw/source/ui/utlui/initui.cxx#244

Again, I'm not sure at all of this.
So I tried to find a way to avoid ImpAutoFmtNameListLoader. I'm waiting
confirmation that behaviour is ok but for the moment,  I can say that, with
this patch, it doesn't crash and the autocorrect seems to work.

Could someone take a look?

Julien




--
View this message in context: http://nabble.documentfoundation.org/PATCH-proposed-patch-for-fdo56549-CRASH-in-menu-Format-Autocorrect-Apply-and-Edit-Changes-tp4020695.html
Sent from the Dev mailing list archive at Nabble.com.