[PATCH] fdo#34897 numbers were wrong, code unnecessary

Lennard Wasserthal (via Code Review) gerrit at gerrit.libreoffice.org
Sun Nov 25 05:13:10 PST 2012


I have submitted a patch for review:


To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/1165/1

fdo#34897 numbers were wrong, code unnecessary

also working, but worse:
        if (nAngle==900) {
        AddOpt( ESCHER_Prop_txflTextFlow, ESCHER_txflBtoT );
        if (nAngle==2700) {
        AddOpt( ESCHER_Prop_txflTextFlow, ESCHER_txflTtoBA );
but: text flow is perhaps not intended to specify rotation, created data may misbehave on
other applications, and there is no reason for this unnecessary special case.
(Especially obvious because there is no text flow that causes 180 deg rotation.)

Change-Id: I0b1cac78e549c2126d7e45298629e28fc76ac95d
Signed-off-by: Lennard <Wasserthal at nefkom.net>
M filter/source/msfilter/escherex.cxx
1 file changed, 0 insertions(+), 12 deletions(-)

To view, visit https://gerrit.libreoffice.org/1165
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b1cac78e549c2126d7e45298629e28fc76ac95d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lennard Wasserthal <Wasserthal at nefkom.net>

More information about the LibreOffice mailing list