Use unabbreviated git SHA1 for buildid

Stephan Bergmann sbergman at redhat.com
Mon Nov 26 06:05:52 PST 2012


On 11/26/2012 01:00 PM, Lior Kaplan wrote:
> I'd like to raise the question why do we need the full SHA1 for as the
> build ID?
> (See
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7e6c8459b15a4fdb9ebb269b27cdeea82c8c5c2)
>
> Using the abbreviated version looks weird enough for users, and I think
> the full version won't add anything.
> Technically they are the same (correct me if I'm wrong).

The abbreviated form is much more prone for collision than the 
unabbreviated one, and the core git repo indeed already has at least one 
collision of abbreviated SHA1s.  Try "git show 349fa28a".

Stephan


More information about the LibreOffice mailing list