opinion needed on feature/download

David Tardon dtardon at redhat.com
Tue Nov 27 05:59:49 PST 2012


On Tue, Nov 27, 2012 at 02:01:59PM +0100, Petr Mladek wrote:
> Matúš Kukan píše v Út 27. 11. 2012 v 13:34 +0100:
> > On 26 November 2012 11:46, Petr Mladek <pmladek at suse.cz> wrote:
> > > It was me who come up with the idea or removing md5sum from the file
> > > name. Well, it was after Matus came up with the idea of introducing .md5
> > > files :-)
> > 
> > Wasn't it David who came up with .md5 files ?
> > https://bugs.freedesktop.org/show_bug.cgi?id=56131#c1
> > But I think he meant to have them in git, not on web.
> I see. The .md5 and even .url file was David's idea and I was not sure
> about the real meaning.

Some of the things I wanted to achieve were:
* make it easy to get all tarballs
  (sed -e 's/\s\+/-/' */*.md5)
* avoid the profusion of variables only used in one place
* make it easy to update the tarball
  (md5sum foo-x.y.tar.gz > foo.md5)
* while it be still possible to download just the used tarballs (for both
  sides: host and build)

I have not thought much about the way to get the list of used tarballs
from gbuild. We could, e.g., create a makefile that redefines
gb_UnpackedTarball_set_tarball (which would now take the md5 file
instead of tarball) to collect tarballs into a variable, loads all
external modules and then prints that variable.

The .url files were purely to allow the current practice of having the
tarballs in more than one place.

And yes, both .md5 and .url would be in git.

> > > As I said, I do not have any strong opinion. If we remove md5sum from
> > > the filename, it will cause extra work for distro package maintainers.
> > > On the other hand, it might be slightly easier in the long term.
> > 
> > Me neither.
> > So, probably does not make sense to discus this unless someone decides
> > we want to change it.

I am for getting rid of the md5 in the tarballs' names. I always thought
there was some reason behind it... This also makes me reluctant to
advance the abovementioned scheme, because it feels like overkill. But
hey, it was just an idea :-)


More information about the LibreOffice mailing list