[PATCH] Change in core[libreoffice-3-6]: bigendian utext mixup triggering regression test failure

Caolán McNamara (via_Code_Review) gerrit at gerrit.libreoffice.org
Wed Nov 28 04:18:05 PST 2012


I have submitted a patch for review:


To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/1188/1

bigendian utext mixup triggering regression test failure

text takes a pointer to a sal_uInt8 buffer but
utext takes a pointer to a sal_Unicode buffer

passing a sal_uInt8 sequence of e.g. "\x0D\x00" to utext only happens
to work on little endian machines to represent 0x000D, its 0x0D00 on

for more excitement text and utext do not share the same logic!
Various special chars are treated different in text vs utext so
we can't simply blindly change utext() calls to text() calls and
get the same behaviour without reworking those.

So keep the text()/utext() calls as they are, but change what's
passed to be the right thing.

Change-Id: I66696530c4a9482690c461146bdcf0a507b39b68
(cherry picked from commit 49f2a69fa7d8eaa23d77519ac29748f4dc3e4c5a)
M writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
1 file changed, 25 insertions(+), 26 deletions(-)

To view, visit https://gerrit.libreoffice.org/1188
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66696530c4a9482690c461146bdcf0a507b39b68
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Caolán McNamara <caolanm at redhat.com>

More information about the LibreOffice mailing list