Change default shape color

Stephan Bergmann sbergman at redhat.com
Thu Nov 29 02:03:09 PST 2012


On 11/29/2012 10:56 AM, Michael Meeks wrote:
> On Thu, 2012-11-29 at 10:48 +0100, Stephan Bergmann wrote:
>> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=895890563cb0cc5fa872bdfd06918a46cdda172d>
>> "Change default shape color" breaks the build (cf. e.g.,
>>
>> I do not know whether we really want that (the commit message gives no
>> rationale, and I think to remember there were already attempts to change
>> that before that ultimately got reverted again, for reasons I cannot
>> remember), so am unsure whether the better fix is to unbreak the failing
>> test or to revert the commit.
>
> 	IIRC, if there is no shape colour specified in the ODF we default to
> blue - Calligra defaults to white (or somesuch). Quite possibly this
> inadvertently interacts with the default colour of the shape - either
> way we should check that the filter logic is providing a back-compatible
> default if that is not specified (I guess).
>
> 	I for one would love to be rid of the blue: it's time for green to have
> it's day ! ;-)

but for now it's red that has it's day

Stephan


More information about the LibreOffice mailing list