[PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code
José Guilherme Vanz
guilherme.sft at gmail.com
Tue Oct 2 04:13:09 PDT 2012
I unterstood... Thanks for comment! I'll do more and better next time
2012/10/1 Thorsten Behrens <thb at documentfoundation.org>
> guilherme.sft at gmail.com wrote:
> > This patch removes '@author' annotation, code in comments
> > and adjust some empty catches. It's cleanup patch
> Hi José Guilherme,
> partially pushed - I left the hunks commenting empty methods as
> FIXME instead of removing them straight away unapplied. If the
> method is pointless, why not remove them in one go?
> I also did not apply your printStackTrace() logging calls, I think
> at least some of them report on exceptions that were seemingly
> previously ignored on purpose?
> Stephan, or anyone else more up-to-date with contemporary java
> idiom, any opinions here?
> Thanks for the nice cleanup anyways! :)
> -- Thorsten
Att. José Guilherme Vanz
"Se você é capaz de tremer de indignação cada vez que se comete uma
injustiça no mundo, então somos companheiros" - Che Guevara
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the LibreOffice